RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v26]
Johannes Bechberger
jbechberger at openjdk.org
Mon Jun 2 08:44:01 UTC 2025
On Sun, 1 Jun 2025 13:01:23 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Refactoring
>> - Remove convoluted native trace logic
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 200:
>
>> 198: void sample_thread(JfrSampleRequest& request, void* ucontext, JavaThread* jt, JfrThreadLocal* tl);
>> 199:
>> 200: // sample all threads that are in native state (and requested to be sampled)
>
> We are not really "sampling", but processing their queues, no?
You're correct.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2120450563
More information about the serviceability-dev
mailing list