RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v38]
Markus Grönlund
mgronlun at openjdk.org
Tue Jun 3 12:44:09 UTC 2025
On Tue, 3 Jun 2025 12:39:47 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509).
>>
>> Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with
>> - ... different heap sizes
>> - ... different GCs
>> - ... different samplers (the standard JFR and the new CPU Time Sampler and both)
>> - ... different JFR recording durations
>> - ... different chunk-sizes
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>
> Restrict threads for which timers are created
src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 63:
> 61: assert(raw_thread->is_Java_thread(), "invariant");
> 62: JavaThread* jt = JavaThread::cast(raw_thread);
> 63: if (is_excluded(jt)) {
and now:
if (is_excluded(jt) || jt->is_exiting()) {
return nullptr;
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2123692657
More information about the serviceability-dev
mailing list