RFR: 8354460: Streaming output for attach API should be turned on by default

[Kevin Walls]

On Mon, 12 May 2025 19:55:58 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The fix turns on streaming output for attach operations.
> Change in HotSpotVirtualMachine.java sets attach client property.
> Change in attachListener.cpp sets server property (used when client does not specify the property in the request - this is the case when attach tool from older release connects to new VM).
> 
> Testing: tier1..tier8

src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line 66:

> 64:         String s = VM.getSavedProperty("jdk.attach.allowAttachSelf");
> 65:         ALLOW_ATTACH_SELF = "".equals(s) || Boolean.parseBoolean(s);
> 66:         // For now the default is false.

Shall we remove the comment?  It was not obvious whether it applied to the code above, or below. 8-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25192#discussion_r2123964340