RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v58]
Markus Grönlund
mgronlun at openjdk.org
Wed Jun 4 19:18:08 UTC 2025
On Wed, 4 Jun 2025 19:11:16 GMT, Andrei Pangin <apangin at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve disenroll
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 656:
>
>> 654: if ((prev_handler != SIG_DFL && prev_handler != SIG_IGN && prev_handler != (void*)::handle_timer_signal) ||
>> 655: PosixSignals::install_generic_signal_handler(SIG, (void*)::handle_timer_signal) == (void*)-1) {
>> 656: log_error(jfr)("CPUTimeSample events will not be recorded: %p", prev_handler);
>
> A message with some random hex address may look cryptic.
> Maybe make it a bit more user-friendly? E.g.
>
> Conflicting SIGPROF handler found: %p. CPUTimeSample events will not be recorded
Thanks Andrei.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2127272864
More information about the serviceability-dev
mailing list