RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v58]

Johannes Bechberger jbechberger at openjdk.org
Wed Jun 4 19:24:11 UTC 2025


On Wed, 4 Jun 2025 18:44:23 GMT, Andrei Pangin <apangin at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve disenroll
>
> src/hotspot/os/posix/signals_posix.cpp line 1511:
> 
>> 1509:   struct sigaction oact;
>> 1510:   if (sigaction(sig, (struct sigaction*)nullptr, &oact) == -1) {
>> 1511:     return nullptr; // signal not installed
> 
> A comment is misleading: sigaction does not fail if a handler for the signal is not installed (i.e. the handler is SIG_IGN).

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2127281710


More information about the serviceability-dev mailing list