RFR: 8352075: Perf regression accessing fields [v26]

[Radim Vansa]

On Mon, 9 Jun 2025 13:23:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Print debugging info for InstanceKlass
>
> src/hotspot/share/oops/fieldInfo.cpp line 132:
> 
>> 130: // We use both name and signature during the comparison; while JLS require unique
>> 131: // names for fields, JVMS requires only unique name + signature combination.
>> 132: typedef struct {
> 
> Style: Use C++ struct def (no typedef), don't use trailing _t in the name and write it as FieldPos. The fields are public, so no underscore as name prefix for them.

Now I am confused; @iklam just requested to use the underscores.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2135747029