RFR: 8358815: Exception event spec has stale reference to catch_klass parameter [v2]

[Alan Bateman]

On Tue, 10 Jun 2025 21:13:11 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Then you also need to fix:
>> 
>> "If there is no such catch clause, each field is set to 0."
>> 
>> Also, technically speaking, can't `catch_location` be 0 even if caught (caught first the bytecode of the method)? Although I doubt  javac would ever generate such code, it seems it is allowed. If so, then `catch_method == null` is the only check  a user should make.
>
> Thank you for the comments!
> Yes, I've also come to the same conclusion about the only `catch_method == null` check.
> 
>> Then you also need to fix:
>> "If there is no such catch clause, each field is set to 0."
> 
> Good catch, thanks.
> 
> The suggestions above have addressed now.
> Also, I've replaced the term `field` with `parameter` for consistency in two spots.

I think what you have looks okay now. I'm just wondering about the description for the catch_location parameter has "zero if no known catch". So if catch_method is null then catch_location must be 0.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25710#discussion_r2139275112