RFR: 8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees [v2]

Leonid Mesnik lmesnik at openjdk.org
Mon Jun 23 16:44:29 UTC 2025


On Thu, 19 Jun 2025 00:33:42 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> [JDK-8333117](https://bugs.openjdk.org/browse/JDK-8333117) removed support for non-local debuggees, so now only local debuggees are supported. However, there are now a lot of references to the "local" debuggee mode which are not necessary because "local" is implied. These references are in comments and API names and should be removed.
>> 
>> Also, after [JDK-8333117](https://bugs.openjdk.org/browse/JDK-8333117), DebugeeProcess no longer needs to be considered abstract. It has no abstract methods.
>> 
>> Tested nsk/jdi, nsk/jdb, and nsk/jdwp locally. Will run tier5 CI to get better coverage.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   startLocalDebugee renamed to startDebugee

Changes requested by lmesnik (Reviewer).

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 50:

> 48:  * @see nsk.share.jdwp.Debugee
> 49:  */
> 50: public class DebugeeProcess {

Are there any reason to make it non-abstract.. Even DebugeeProcess doesn't have abstract methods, only jid/jdwp subclasses might be used.Might be left it abstract?

-------------

PR Review: https://git.openjdk.org/jdk/pull/25887#pullrequestreview-2950764480
PR Review Comment: https://git.openjdk.org/jdk/pull/25887#discussion_r2162039309


More information about the serviceability-dev mailing list