RFR: 8359870: JVM crashes in AccessInternal::PostRuntimeDispatch [v4]

[Alan Bateman]

On Wed, 25 Jun 2025 12:02:11 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> ThreadDumper/ThreadSnapshot need to handle a failure to resolve the native VM JavaThread from a java.lang.Thread.  This is hard to reproduce but a thread that has since terminated can provoke a crash.  Recognise this and return a null ThreadSnapshot.
>
> Kevin Walls has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - newline
>  - Test fails on minimal VM: require jvmti feature

src/java.base/share/classes/jdk/internal/vm/ThreadDumper.java line 317:

> 315:         ThreadSnapshot snapshot = ThreadSnapshot.of(thread);
> 316:         if (snapshot == null) {
> 317:             return false; // Terminated

This is okay. Do you mind change these two to say "thread terminated"?  We will eventually replace this as it's only a temporary that this scenario is even possible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25958#discussion_r2166601207