RFR: 8358624: ImmutableDescriptor violates equals/hashCode contract after deserialization [v3]

Chris Plummer cjplummer at openjdk.org
Wed Jun 25 17:48:28 UTC 2025


On Wed, 25 Jun 2025 17:28:11 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Hashcode needs to be reset to -1 to force its recalculation on next call, after deserialization.
>> 
>> The change in the readResolve() method is the fix for this problem.  While here I added similar lines in other methods that may update fields (although these are noted as not supported, as they change a class supposedly "immutable").
>> 
>> Added a test.  There is a test for serialization for this class, but I found it clearer to add the test for this specific recently discovered issue in its own test file.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more comments!

Looks good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25758#pullrequestreview-2959116228


More information about the serviceability-dev mailing list