RFR: 8359707: Add classfile modification code to RedefineClassHelper [v6]

Leonid Mesnik lmesnik at openjdk.org
Thu Jun 26 05:05:30 UTC 2025


On Wed, 25 Jun 2025 21:00:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I copied this code for another test in the Valhalla repo and thought it would be a good utility function.  It might be better written using the Classfile API.
>> Tested with test.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Made it even shorter.

Looks

test/lib/RedefineClassHelper.java line 35:

> 33: import jdk.test.lib.helpers.ClassFileInstaller;
> 34: 
> 35: import static jdk.test.lib.Asserts.assertTrue;

Is it really needed? I can't see that assertion were added.

-------------

Changes requested by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25857#pullrequestreview-2960558507
PR Review Comment: https://git.openjdk.org/jdk/pull/25857#discussion_r2168113468


More information about the serviceability-dev mailing list