RFR: 8268406: Deallocate jmethodID native memory [v10]
Daniel D. Daugherty
dcubed at openjdk.org
Thu Jun 26 16:38:37 UTC 2025
On Thu, 26 Jun 2025 12:08:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/runtime/mutexLocker.cpp line 236:
>>
>>> 234: MUTEX_DEFN(Notification_lock , PaddedMonitor, service); // used for notification thread operations
>>> 235:
>>> 236: MUTEX_DEFN(JmethodIdCreation_lock , PaddedMutex , nosafepoint-1); // used for creating jmethodIDs locks HandshakeState_lock
>>
>> Perhaps:
>>
>> MUTEX_DEFN(JmethodIdCreation_lock , PaddedMutex , nosafepoint-1); // used for creating jmethodIDs, can lock HandshakeState_lock which is at nosafepoint
>
> ugh that makes the line too long for me.
How about just: s/locks/can also lock/
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25267#discussion_r2169462310
More information about the serviceability-dev
mailing list