RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

Thu Mar 13 13:31:59 UTC 2025

On Thu, 13 Mar 2025 11:39:14 GMT, snake66 <duke at openjdk.org> wrote:

>> Allows for future support for platforms that require different flags for libiconv support.
>> 
>> Sponsored-by: The FreeBSD Foundation
>
> snake66 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Unbreak libjdwp build

This looks good to me now.

Then I think the current solution is fine. Even if OpenBSD is not the primary goal of your port, I see no reason to actively work against it either, so if it needs `ICONV_LDFLAGS` then we should include it.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23995#pullrequestreview-2681916914
PR Comment: https://git.openjdk.org/jdk/pull/23995#issuecomment-2721263178