RFR: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK

[Thomas Stuefe]

On Sat, 22 Feb 2025 03:31:53 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

> Please review the fix in following tests to not check for shared libraries when running on static JDK:
> 
> test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java

Small nits, otherwise fine.

test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java line 97:

> 95:             regexBase_committed + "/lib/.*/libjvm.so"
> 96:         };
> 97: 

Nit, misnamed, since its not unconditionally anymore.

test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java line 115:

> 113:             } else {
> 114:                 return StringArrayUtils.concat(shouldMatchUnconditionally_linux,
> 115:                                                shouldMatchUnconditionally_linux_libjvm);

Here, and in DumpTest: please provide a short comment about why we don't want to match libjvm (even if it seems obvious).

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23734#pullrequestreview-2683177865
PR Review Comment: https://git.openjdk.org/jdk/pull/23734#discussion_r1994192659
PR Review Comment: https://git.openjdk.org/jdk/pull/23734#discussion_r1994195194