RFR: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Mar 14 06:18:03 UTC 2025
On Thu, 13 Mar 2025 22:46:54 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review the fix in following tests to not check for shared libraries when running on static JDK:
>>
>> test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java
>> test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java
>> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Address @tstuefe review:
> - Renamed shouldMatchUnconditionally_<os>_libjvm to shouldMatch_<os>_libjvm in SystemMapTestBase.
> - Added comments to shouldMatchUnconditionally() methods for difference OS cases in SystemMapTestBase.
> - Added comments to DynLibsTest.java.
Good, thanks for addressing the nits
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23734#pullrequestreview-2684430340
More information about the serviceability-dev
mailing list