Integrated: 8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called
Leonid Mesnik
lmesnik at openjdk.org
Sat Mar 22 02:03:11 UTC 2025
On Thu, 13 Mar 2025 19:02:08 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> The nsk_jvmti_setFailStatus() sometimes is called after test check results. In these cases the warning logs are generated and hide the real failure reasons. Also, I think it is a error-prone way to set and check error, since check might be just forgotten. Also, the test execution after failure might be incorrect and also make failure analysis harder.
> So I think it makes sense to always fail when nsk_jvmti_setFailStatus() is called.
>
> If this is going to work I'll rename it later and add add optional message to be more informative.
This pull request has now been integrated.
Changeset: 334a1eec
Author: Leonid Mesnik <lmesnik at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/334a1eec2375a4f9f3150bdb556c1c2432596b4b
Stats: 70 lines in 5 files changed: 46 ins; 19 del; 5 mod
8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called
Reviewed-by: sspitsyn, cjplummer
-------------
PR: https://git.openjdk.org/jdk/pull/24040
More information about the serviceability-dev
mailing list