RFR: 8356177: Regression after JDK-8352180

[Serguei Spitsyn]

On Tue, 13 May 2025 20:49:14 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The fix handles a special case when `AttachListener::dequeue()` fails to read/parse attach command request and 'PipeChannel' destructor is called when the current thread is `blocked`.
> 
> Testing: tier1..4,hs-tier5-svc

This looks good but posted one question.

test/hotspot/jtreg/serviceability/attach/FailedDequeueTest.java line 64:

> 62:         } catch (IOException ex) {
> 63:             System.out.println("OK: setFlag thrown expected exception:");
> 64:             ex.printStackTrace(System.out);

Nit: If an `IOException` is expected then should we report a test failure after the line 61 in a case `IOException` was not thrown?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25219#pullrequestreview-2839712737
PR Review Comment: https://git.openjdk.org/jdk/pull/25219#discussion_r2088653595