RFR: 8353955: nsk/jdi tests should be fixed to not always require includevirtualthreads=y [v4]

[Chris Plummer]

On Wed, 14 May 2025 08:19:02 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> Looks okay in general. Many files still need a copyright update.

I'll update after the merge with 2 other PRs that this PR is dependent on.

> test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequestManager/accessWatchpointRequests/accwtchpreq002.java line 251:
> 
>> 249:         String lineForComm  = "lineForComm";
>> 250: 
>> 251:         //ThreadReference   mainThread = debuggee.threadByNameOrThrow("main");
> 
> Q: Do you want to keep this commented out line?

I thought I had undone that. This test is fixed in another PR, but I had experimented with the fix here first. I'll remove it.

> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeArgumentHandler.java.orig line 1:
> 
>> 1: /*
> 
> I guess, this temporary file was checked in by a mistake.

Good catch. At some point I did a "git add -a", not knowing that this filing was lingering around. I'll remove it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24606#issuecomment-2880959336
PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2089384545
PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2089386062