RFR: 8357193: [VS 2022 17.14] Warning C5287 in debugInit.c: enum type mismatch during build

[Serguei Spitsyn]

On Mon, 19 May 2025 05:26:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> I can suppress it by extracting JVMTI_VERSION into local variable similar to how other code looks like:
>
>    jint version = JVMTI_VERSION;
>    jvmtiCompileTimeMajorVersion  = ( version & JVMTI_VERSION_MASK_MAJOR )
>                                        >> JVMTI_VERSION_SHIFT_MAJOR;
>    jvmtiCompileTimeMinorVersion  = ( version & JVMTI_VERSION_MASK_MINOR )
>                                        >> JVMTI_VERSION_SHIFT_MINOR;
>    jvmtiCompileTimeMicroVersion  = ( version & JVMTI_VERSION_MASK_MICRO )
>                                        >> JVMTI_VERSION_SHIFT_MICRO;
>
> but it might be better just suppress it in the make file?

I like the suggestion to extract JVMTI_VERSION into a local variable. Fixing it in the make file is fine too.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25293#issuecomment-2891829112