RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates [v2]

[Alan Bateman]

On Sat, 24 May 2025 09:37:21 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreadsWithEliminatedLock.java line 83:
> 
>> 81:                 sb.append(System.currentTimeMillis());
>> 82:                 String s = sb.toString();
>> 83:                 ref.set(s);
> 
> Suggestion:
> 
>                 ref.set(
>                         new StringBuffer()
>                                 .append(System.currentTimeMillis())
>                                 .toString());

This looks a lot less readable so I don't think we should change it.

> test/lib/jdk/test/lib/threaddump/ThreadDump.java line 385:
> 
>> 383:             if (name.length() > 0) {
>> 384:                 sb.append(",");
>> 385:                 sb.append(name);
> 
> Suggestion:
> 
>                 sb.append(",")
>                   .append(name);

okay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25429#discussion_r2111405917
PR Review Comment: https://git.openjdk.org/jdk/pull/25429#discussion_r2111404857