RFR: 8356548: Avoid using ASM to parse latest class files in tests [v4]

Andrew Haley aph at openjdk.org
Thu May 29 09:37:54 UTC 2025


On Fri, 9 May 2025 22:34:45 GMT, Chen Liang <liach at openjdk.org> wrote:

>> For early eval; test by changing the ClassReader max accepted version of test ASM to 24 instead of 25
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Move other tier 4,5, etc tests to not use ClassReader
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>  - Use classfile api instead of javac setting version
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>  - 8356548: Avoid using ASM to parse latest class files in tests

test/hotspot/jtreg/compiler/calls/common/InvokeDynamicPatcher.java line 79:

> 77:                     }
> 78: 
> 79:                     /* a code generate looks like

Suggestion:

                    /* the code generated looks like

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25124#discussion_r2113583647


More information about the serviceability-dev mailing list