RFR: 8357172: Extend try block in nsk/jdi tests to capture exceptions thrown by Debuggee.classByName()

Serguei Spitsyn sspitsyn at openjdk.org
Thu May 29 10:02:52 UTC 2025


On Tue, 20 May 2025 20:10:20 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Extend try block to cover debuggee.classByname() call. I would suggest disabling whitespace diffs when doing the review. It makes code movement and deletions more obvious.
> 
> There are a number of places where I removed a try/catch of InterruptedException around a Thread.sleep. This will now be handled by the outer try which was moved to before this try/catch.
> 
> Tested nsk/jdi test locally. Will do more thorough ci testing.

Looks good. Nice refactoring.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25337#pullrequestreview-2877741782


More information about the serviceability-dev mailing list