RFR: 8357172: Extend try block in nsk/jdi tests to capture exceptions thrown by Debuggee.classByName() [v2]

Chris Plummer cjplummer at openjdk.org
Thu May 29 17:02:09 UTC 2025


> Extend try block to cover debuggee.classByname() call. I would suggest disabling whitespace diffs when doing the review. It makes code movement and deletions more obvious.
> 
> There are a number of places where I removed a try/catch of InterruptedException around a Thread.sleep. This will now be handled by the outer try which was moved to before this try/catch.
> 
> Tested nsk/jdi test locally. Will do more thorough ci testing.

Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:

  minor whitespace fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25337/files
  - new: https://git.openjdk.org/jdk/pull/25337/files/1ed374f5..d94c056d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25337&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25337&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/25337.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25337/head:pull/25337

PR: https://git.openjdk.org/jdk/pull/25337


More information about the serviceability-dev mailing list