RFR: 8345745: Update mode of the Attach API communication pipe.
Alex Menkov
amenkov at openjdk.org
Thu May 29 19:25:59 UTC 2025
Please review this small fix to update pipe mode for attach operation communication.
- `FILE_FLAG_FIRST_PIPE_INSTANCE`: there is "retry" logic if pipe creation failed [1], with this flag `CreateNamedPipe` fails when pipe with the same name already exists;
- `PIPE_REJECT_REMOTE_CLIENTS`: attach works only for local processes, the flag adds extra protection from remote connections.
[1]: https://github.com/openjdk/jdk/blob/master/src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java#L93
Testing: tier1..4, hs-tier5-svc
-------------
Commit messages:
- fix
Changes: https://git.openjdk.org/jdk/pull/25530/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25530&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8345745
Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/25530.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25530/head:pull/25530
PR: https://git.openjdk.org/jdk/pull/25530
More information about the serviceability-dev
mailing list