Integrated: 8353955: nsk/jdi tests should be fixed to not always require includevirtualthreads=y

Chris Plummer cjplummer at openjdk.org
Fri May 30 17:39:01 UTC 2025


On Fri, 11 Apr 2025 23:23:52 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> What this PR is fixing is the issue with all of our nsk/jdi testing being done with includevirtualthreads=y even though debuggers typically use the default includevirtualthreads=n. As a result we have a testing gap with includevirtualthreads=n.
> 
> includevirtualthreads=y forces the debug agent to track all virtual threads so they are returned by vm.allThreads(). Some tests need this since they use vm.allThreads() to find the debuggee threads. Without includevirtualthreads=y, vm.allThreads() usually won't return any virtual threads (although it might return some for which events have been triggered).
> 
> There are nearly 1200 nsk/jdi tests. There were about 350 tests that actually needed includevirtualthreads=y, but most of these have been addressed by other PRs, leaving the 20 or so tests being addressed in this PR. With this PR now defaulting to includevirtualthreads=n, the tests that require includevirtualthreads=y need to override the default by specifying the -includevirtualthreads @run option.

This pull request has now been integrated.

Changeset: 3cc63098
Author:    Chris Plummer <cjplummer at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3cc630985d47be6ba4cf991698e999f17dbde203
Stats:     72 lines in 25 files changed: 37 ins; 0 del; 35 mod

8353955: nsk/jdi tests should be fixed to not always require includevirtualthreads=y

Reviewed-by: sspitsyn, amenkov, lmesnik

-------------

PR: https://git.openjdk.org/jdk/pull/24606


More information about the serviceability-dev mailing list