RFR: 8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114

Serguei Spitsyn sspitsyn at openjdk.org
Fri May 30 18:59:51 UTC 2025


On Thu, 29 May 2025 19:14:06 GMT, Larry Cable <duke at openjdk.org> wrote:

> JDK-8358077:sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114
> 
> modified the code to place the `Files::lines` in a `try-with-resources` block in order to autoclose the `Stream` and underlying file resources immediately.

Looks good.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25529#pullrequestreview-2882258269


More information about the serviceability-dev mailing list