RFR: 8351194: Clean up Hotspot SA after 32-bit x86 removal [v8]
Aleksey Shipilev
shade at openjdk.org
Tue Nov 4 10:57:03 UTC 2025
On Thu, 30 Oct 2025 11:43:26 GMT, Kerem Kat <krk at openjdk.org> wrote:
>> Remove 32-bit x86 specific code from the HotSpot Serviceability Agent following the removal of 32-bit x86 support.
>>
>> - Removed x86-specific implementations and ifdef blocks.
>> - Renamed files with X86 in the name when they are also used from AMD64, e.g. `X86Frame` → `AMD64Frame`.
>> - Cleaned up platform detection logic in `PlatformInfo`.
>> - Updated documentation references.
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
>
> Erase obsolete comments
I believe all reviewers are in agreement, and you need just another (re-)review to pass the automated checks. I skimmed through the change, and it looks reasonable to me. Thanks!
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27844#pullrequestreview-3415701693
More information about the serviceability-dev
mailing list