RFR: 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests
Leonid Mesnik
lmesnik at openjdk.org
Thu Nov 13 16:23:43 UTC 2025
On Sat, 8 Nov 2025 08:10:45 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property from "jdk.test.docker.retain.image" do not work for some of the docker tests, such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only works for some of the docker tests, such as jdk/internal/platform/docker/TestPidsLimit.java.
>
> This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function removeDockerImage instead of before all the fucntion removeDockerImage. This will make all the docker tests receive the property jdk.test.docker.retain.image.
>
> Change has been verified locally on linux-x64 by run the all touched tests.
Marked as reviewed by lmesnik (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28208#pullrequestreview-3460609576
More information about the serviceability-dev
mailing list