RFR: 8370203 - Add jcmd AOT.end_recording diagnostic command [v3]

Mat Carter macarte at openjdk.org
Wed Nov 19 23:06:00 UTC 2025


On Fri, 14 Nov 2025 18:12:04 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Document use of DiagnosticCommand
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1000:
> 
>> 998:   if (!AOTMetaspace::is_recording_preimage_static_archive()) {
>> 999:     output()->print_cr("Error! Not recording");
>> 1000:     return;
> 
> This check is confusing because your error message is cryptic.
> Actually I think you don't need any message here - it is not error. Use comment instead:
> 
>   // The other thread already initiated end of recording.

I've changed the message to be less cryptic, but the message should still be returned to whoever invoked the command

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27965#discussion_r2543825605


More information about the serviceability-dev mailing list