RFR: 8370203 - Add jcmd AOT.end_recording diagnostic command [v5]

[Mat Carter]

On Fri, 21 Nov 2025 00:56:46 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Mat Carter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8370203' of https://github.com/macarte/jdk into JDK-8370203
>>  - Corrected placement of assert and logic test
>
> src/hotspot/share/cds/aotMetaspace.cpp line 1062:
> 
>> 1060: bool AOTMetaspace::preimage_static_archive_dumped() {
>> 1061:   assert(CDSConfig::is_dumping_preimage_static_archive(), "Required");
>> 1062:   return _preimage_static_archive_dumped == 1;
> 
> Should it be  AtomicAccess::load(&_preimage_static_archive_dumped) here?

Andrew brought this up also; I'll add but should it be AtomicAccess::load or AtomicAccess::load_acquire?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27965#discussion_r2550681782