RFR: 8371380: [LOOM] The debug agent should avoid enabling VIRTUAL_THREAD_START/END events when possible [v2]
Chris Plummer
cjplummer at openjdk.org
Thu Nov 27 01:36:25 UTC 2025
On Thu, 27 Nov 2025 00:59:46 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.c line 1691:
>>
>>> 1689: * a deferred event request.
>>> 1690: */
>>> 1691: if (gdata->virtualThreadStartEventsPermanentlyEnabled) {
>>
>> Looks like this block can disable VITRUAL_THREAD_START when `rememberVThreadsWhenDisconnected` is set.
>
> virtualThreadStartEventsPermanentlyEnabled is only set true if includeVThreads is false, which means rememberVThreadsWhenDisconnected is also false (they are always set the same, as I discuss in my new comment below).
>
> virtualThreadStartEventsPermanentlyEnabled could use a better name because it means "permanently enabled for handling deferred event enabling", whereas if includeVThreads is true, VITRUAL_THREAD_START events are always permanently enabled, but virtualThreadStartEventsPermanentlyEnabled will never be set true.
How about virtualThreadStartEventsEnabledForDeferredEventMode?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28485#discussion_r2566914246
More information about the serviceability-dev
mailing list