RFR: 8356548: Use ClassFile API instead of ASM to transform classes in tests [v7]

[Chen Liang]

On Wed, 15 Oct 2025 06:01:01 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>>  - Ioi review
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>>  - Merge branch 'fix/asm-test-upgrade' of github.com:liachmodded/jdk into fix/asm-test-upgrade
>>  - Update test/hotspot/jtreg/compiler/calls/common/InvokeDynamicPatcher.java
>>    
>>    Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>>  - Variable name improvements
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/63a83778...25972f2d
>
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAnnotations.java line 94:
> 
>> 92:                 public void accept(ClassBuilder builder, ClassElement element) {
>> 93:                     if (element instanceof FieldModel field && field.fieldName().stringValue().startsWith("dummy")) {
>> 94:                         // Remove dummy field
> 
> Q: Is this dummy field removed or added? Seems to be a mismatch between the comment and the real action.

Updated to indicate this shuffle is done to shuffle constant pools.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25124#discussion_r2433349624