RFR: 8321687: Test vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t002/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE [v4]
Leonid Mesnik
lmesnik at openjdk.org
Fri Oct 17 02:22:18 UTC 2025
On Fri, 17 Oct 2025 00:29:41 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - space added
>> - fix
>> - fixed applied
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t001/tc03t001.cpp line 151:
>
>> 149: return NSK_FALSE;
>> 150:
>> 151: for (i = 0; i < debuggee_thread_cnt; i++) {
>
> The fix looks incomplete.
> There is global `threads_count` variable and it's used in a number of places in the file.
> I think it would be simpler to add local `total_thread_count` and use it only to initialize `threadList` (`GetAllThreads`, allocate `threadList`, iteration through `threads`); `debuggee_thread_cnt` needs to be replaced with `threads_count`
Thank you! You are correct, the `debuggee_thread_cnt` is made global and used while printing locks.
I also renamed it to `debuggee_threads_cnt`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27831#discussion_r2438036929
More information about the serviceability-dev
mailing list