RFR: 8370071: Clarify jcmd Thread.print help message [v2]
Sean Coffey
coffeys at openjdk.org
Fri Oct 17 10:25:43 UTC 2025
On Fri, 17 Oct 2025 10:14:13 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>>
>> man page and better help messages
>
> src/hotspot/share/services/diagnosticCommand.hpp line 361:
>
>> 359: return "Print all platform threads with stacktraces. "
>> 360: "Use Thread.dump_to_file command for extended threads "
>> 361: "detail including virtual thread information.";
>
> Can you try "Print all platform threads, and mounted virtual threads, with stack traces"?
>
> Not sure about the second line. I assume you are proposing to add this in order to created awareness but saying "extended threads detail" is confusing. If a second line is added then it could be very simple, e.g. "The Thread.dump_to_file command will print all threads to a file".
yes - nice to have the "mounted virtual threads" clarity.
"The Thread.dump_to_file command will print all threads to a file". --> Will run with that. thanks.
I think it's useful to hint at these commands when end users are reading such help messages.
(e.g. "I want to print thread information but this command is telling me I only get platform + mounted threads.. what do I use for all threads etc.")
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27861#discussion_r2439203942
More information about the serviceability-dev
mailing list