RFR: 8370071: Clarify jcmd Thread.print help message [v3]
Sean Coffey
coffeys at openjdk.org
Mon Oct 20 11:26:43 UTC 2025
On Mon, 20 Oct 2025 10:03:12 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Further help message tweaks
>
> src/hotspot/share/services/diagnosticCommand.hpp line 361:
>
>> 359: return "Print all platform threads, and mounted virtual threads, "
>> 360: "with stack traces. The Thread.dump_to_file command will "
>> 361: "print all threads to a file.";
>
> I'm still in two minds about having it mention Thread.dump_to_file. If it is mentioned then it would be better to put in a line break and use "may be used to" that rather than "will".
yes - happy to tweak this in follow on issue if necessary. I think it reads fine as is but let me know the final format and I'll file a new PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27861#discussion_r2444735331
More information about the serviceability-dev
mailing list