RFR: 8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE [v13]

[Francesco Andreuzzi]

On Mon, 20 Oct 2025 21:01:08 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix tool call
>
> test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/TestEarlyDynamicLoad.java line 35:
> 
>> 33: import java.io.InputStream;
>> 34: import java.util.Objects;
>> 35: import java.util.concurrent.TimeUnit;
> 
> Unused imports

bd4b98a7ad038a4516db7caa8d62204ba760a79c

> test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/TestEarlyDynamicLoad.java line 99:
> 
>> 97: 
>> 98:         ProcessBuilder pb = new ProcessBuilder(jcmd.getCommand());
>> 99:         OutputAnalyzer out = new OutputAnalyzer(pb.start());
> 
> I'd suggest to use `jdk.test.lib.dcmd.PidJcmdExecutor`
> Then this can be simplified to something like
> 
> 
> OutputAnalyzer out = new PidJcmdExecutor().execute("JVMTI.agent_load some.jar");

Thanks, fixed in bd4b98a7ad038a4516db7caa8d62204ba760a79c

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27766#discussion_r2447476586
PR Review Comment: https://git.openjdk.org/jdk/pull/27766#discussion_r2447476248