RFR: 8351194: Clean up Hotspot SA after 32-bit x86 removal [v4]

David Holmes dholmes at openjdk.org
Wed Oct 22 02:22:11 UTC 2025


On Tue, 21 Oct 2025 15:19:35 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Remove 32-bit x86 specific code from the HotSpot Serviceability Agent following the removal of 32-bit x86 support.
>> 
>> - Removed x86-specific implementations and ifdef blocks.
>> - Renamed files with X86 in the name when they are also used from AMD64, e.g. `X86Frame` → `AMD64Frame`.
>> - Cleaned up platform detection logic in `PlatformInfo`.
>> - Updated documentation references.
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   requires hsdis

test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeIntIdealizationTests.java line 34:

> 32:  * @library /test/lib /
> 33:  * @run driver compiler.c2.irTests.RotateLeftNodeIntIdealizationTests
> 34:  * @requires os.arch == "x86_64" | os.arch == "amd64" | os.arch == "aarch64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*zbb.*")

Do not fix this as part of this PR as it is unrelated.

test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeLongIdealizationTests.java line 34:

> 32:  * @library /test/lib /
> 33:  * @run driver compiler.c2.irTests.RotateLeftNodeLongIdealizationTests
> 34:  * @requires os.arch == "x86_64" | os.arch == "amd64" | os.arch == "aarch64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*zbb.*")

Do not fix this as part of this PR as it is unrelated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27844#discussion_r2450225977
PR Review Comment: https://git.openjdk.org/jdk/pull/27844#discussion_r2450226326


More information about the serviceability-dev mailing list