RFR: 8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE [v16]
Francesco Andreuzzi
fandreuzzi at openjdk.org
Wed Oct 22 08:41:20 UTC 2025
On Tue, 21 Oct 2025 22:49:35 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> cc
>
> test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/TestEarlyDynamicLoad.java line 47:
>
>> 45: * @run junit TestEarlyDynamicLoad
>> 46: */
>> 47: public class TestEarlyDynamicLoad {
>
> Nit: It is convenient if the test folder name matches the test class name. There are several cases where this is broken in our testbase. But it is still a good idea to keep this invariant where possible.
Renamed in 1dafec32b57ac557b66dfe91c4bd2964019c9ff1
> test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/libEarlyDynamicLoad.cpp line 54:
>
>> 52: fprintf(stderr, "JVMTI error occurred during SetEventNotificationMode\n");
>> 53: return 1;
>> 54: }
>
> Nit: The returned values have to be JNI_ERR or JNI_OK.
Fixed in 205967939772764946e3df0e1633d6cec9e7d4a1
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27766#discussion_r2450933247
PR Review Comment: https://git.openjdk.org/jdk/pull/27766#discussion_r2450933709
More information about the serviceability-dev
mailing list