RFR: 8367982: Unify ObjectSynchronizer and LightweightSynchronizer

[Fredrik Bredberg]

On Fri, 24 Oct 2025 11:14:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is the last PR in a series of PRs (see: [JDK-8344261](https://bugs.openjdk.org/browse/JDK-8344261)) to obsolete the LockingMode flag and related code.
>> 
>> The main focus is to to unify `ObjectSynchronizer` and `LightweightSynchronizer`.
>> There used to be a number of "dispatch functions" to redirect calls depending on the setting of the `LockingMode` flag.
>> Since we now only have lightweight locking, there is no longer any need for those dispatch functions, so I removed them.
>> To remove the dispatch functions I renamed the corresponding lightweight functions and call them directly.
>> This ultimately led me to remove "lightweight" from the function names and go back to "fast" instead, just to avoid having some with, and some without the "lightweight" part of the name.
>> 
>> This PR also include a small simplification of `ObjectSynchronizer::FastHashCode`.
>> 
>> Tested tier1-7 (on supported platforms) without seeing any problems that can be traced to this code change.
>> All other platforms (`arm`, `ppc`, `riscv`, `s390`) has been sanity checked using QEMU.
>
> src/hotspot/share/runtime/synchronizer.inline.hpp line 40:
> 
>> 38:     return read_monitor(mark);
>> 39:   } else {
>> 40:     return ObjectSynchronizer::get_monitor_from_table(current, obj);
> 
> I don't think there's a need for this file anymore.  read_monitor is mostly called inside synchronizer.cpp, so it can be inlined there.

Would you want me to do that in this PR? Or should I create a new RFE for that, just to acknowledge the fact that one should never say "last" cleanup. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27915#discussion_r2460616703