RFR: 8366475: Rename MetaspaceShared class to AOTMetaspace [v3]

[Ashutosh Mehra]

On Sat, 30 Aug 2025 18:17:42 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This PR is one (of many) steps in [JDK-8366473](https://bugs.openjdk.org/browse/JDK-8366473) (Refactor CDS source code with new AOT terminology):
>> 
>> Rename this class to with a naming convention that's consistent with other new AOT classes such as AOTClassLinker.
>> 
>> All changes are mechanical text replacement. Headers are resorted alphabetically.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unnecessary includes

src/hotspot/os/posix/vmError_posix.cpp line 27:

> 25: 
> 26: #include "cds/cdsConfig.hpp"
> 27: #include "cds/aotMetaspace.hpp"

There are few places, like this, where the header files are no longer in sorted order. Can you please update them.

src/hotspot/os/windows/vmError_windows.cpp line 26:

> 24: 
> 25: #include "cds/cdsConfig.hpp"
> 26: #include "cds/aotMetaspace.hpp"

header files are not sorted

src/hotspot/share/prims/jvm.cpp line 3507:

> 3505:   Handle file_handle(THREAD, JNIHandles::resolve_non_null(listFileName));
> 3506:   char* file_name  = java_lang_String::as_utf8_string(file_handle());
> 3507:   AOTMetaspace::dump_loaded_classes(file_name, THREAD);

Shouldn't this file include `aotMetaspace.hpp` directly?

src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 26:

> 24: 
> 25: #include "cds/cdsConfig.hpp"
> 26: #include "cds/aotMetaspace.hpp"

headers are not sorted

src/hotspot/share/prims/whitebox.cpp line 30:

> 28: #include "cds/filemap.hpp"
> 29: #include "cds/heapShared.hpp"
> 30: #include "cds/aotMetaspace.hpp"

header files are not sorted

src/hotspot/share/runtime/java.cpp line 451:

> 449: 
> 450:   if (CDSConfig::is_dumping_preimage_static_archive()) {
> 451:     AOTMetaspace::preload_and_dump(thread);

Shouldn't this file include `aotMetaspace.hpp` directly?

src/hotspot/share/runtime/threads.cpp line 31:

> 29: #include "cds/cdsConfig.hpp"
> 30: #include "cds/heapShared.hpp"
> 31: #include "cds/aotMetaspace.hpp"

header files are not sorted

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320608881
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320608974
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320609474
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320609545
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320609580
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320609638
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2320609704