RFR: 8365192: post_meth_exit should be in vm state when calling get_jvmti_thread_state [v5]

[Martin Doerr]

On Mon, 8 Sep 2025 15:36:45 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more changes reverted
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1844:
> 
>> 1842:   BasicType type = current_frame.interpreter_frame_result(&oop_result, &value);
>> 1843:   assert(type == T_VOID || current_frame.interpreter_frame_expression_stack_size() > 0,
>> 1844:           "Stack shouldn't be empty");
> 
> I think this assertion needs an adaptation. The expression stack can be empty for native method calls. The result does not necessarily need to be on the expression stack depending on the platform.
> Or what else is the reason it is expected to be non-empty?

Thanks for adding the native check! Looks good to me, now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27112#discussion_r2330715809