RFR: 8365192: post_meth_exit should be in vm state when calling get_jvmti_thread_state [v3]
Leonid Mesnik
lmesnik at openjdk.org
Mon Sep 8 18:35:15 UTC 2025
On Mon, 8 Sep 2025 05:42:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - small improvements
>> - Merge branch 'master' of https://github.com/openjdk/jdk into 8365192-2
>> - comment
>> - comment is fixed.
>> - fix
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1857:
>
>> 1855: BasicType type, Handle result, jvalue value) {
>> 1856: JvmtiThreadState* state; // should be initialized in vm state only
>> 1857: JavaThread* current = thread; // for JRT_BLOCK
>
> If `thread` is always the current thread then I suggest just calling it `current` in the first place.
This line no remains unchanged. I also reverted some unnecessary changes so let keep fix minimal.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27112#discussion_r2331054856
More information about the serviceability-dev
mailing list