RFR: 8367609: serviceability/sa/ClhsdbPmap.java fails when built with Clang [v2]

[Francesco Andreuzzi]

On Mon, 15 Sep 2025 20:14:35 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 432:
> 
>> 430:             // We should trust the core dump in this case.
>> 431:             continue;
>> 432:           }
> 
> If this added check passes, then you will ignore any error that may have been caught by the previous page_size and lib_fd checks. I think you will need to redo those here before doing the continue. The other choice is to add this extra check to the original `if` condition, and require that just one of the two  `ROUNDUP(existing_map->memsz, page_size)` checks passes.

Thanks for pointing that out, I fixed the problem in 5b5940803c373fa5ea000c673cf52625abaaefb8

Let me know if you see other inconsistencies

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27274#discussion_r2350352203