RFR: 8367725: Incorrect reading of oop in SuspendResumeManager::suspend while thread is blocked [v5]
Leonid Mesnik
lmesnik at openjdk.org
Tue Sep 16 19:50:38 UTC 2025
On Tue, 16 Sep 2025 19:12:09 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>>
>> ident fixed
>
> src/hotspot/share/runtime/suspendResumeManager.cpp line 105:
>
>> 103: // If target is the current thread we can bypass the handshake machinery
>> 104: // and just suspend directly
>> 105: self_suspend(register_vthread_SR, self);
>
> Since `self_suspend()` is a very short method and only called from here, I would keep the method as it was and if anything define `set_suspended_with_id(int64_t id, bool register_vthread_SR)` instead.
Thanks, moved. Also the include defines become correct.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27317#discussion_r2353501079
More information about the serviceability-dev
mailing list