RFR: 8362561: Remove diagnostic option AllowArchivingWithJavaAgent

[David Holmes]

On Tue, 16 Sep 2025 03:52:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Goal: simplify AOT implementation and removed unnecessary tests:
> 
> This PR removes old CDS tests that use java agents during CDS dump (to increase test coverage by triggering conditions, such as GCs, that were not happening during usual `java -Xshare:dump` operations).
> 
> Since AOT assembly is much more complex now, we have enough coverage. These old tests are no longer necessary.
> 
> With these tests removed, we no longer need the `-XX:-AllowArchivingWithJavaAgent` diagnostic flag, which has been abused by users despite the warning that this flag should not be used in production.

Seems like a nice cleanup and simplification.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27304#pullrequestreview-3232124747