RFR: 8367725: Incorrect reading of oop in SuspendResumeManager::suspend while thread is blocked [v8]

[Leonid Mesnik]

On Wed, 17 Sep 2025 04:05:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fixed
>
> src/hotspot/share/runtime/suspendResumeManager.hpp line 61:
> 
>> 59: 
>> 60:   void set_suspended(bool to, bool register_vthread_SR);
>> 61:   void set_suspended_with_id(int64_t id, bool register_vthread_SR);
> 
> Some descriptive comments would be useful now due to the difference in meaning for "suspended". Personally I think we should have `set_suspended` and `set_resumed` rather than passing true/false for the suspend state.

I added comment. The set_suspended(bool..) -> set_suspended/set_resumed makes sense since we usually have have suspend/resume pair. I'll look on this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27317#discussion_r2355815267