RFR: 8367725: Incorrect reading of oop in SuspendResumeManager::suspend while thread is blocked [v9]

David Holmes dholmes at openjdk.org
Wed Sep 17 20:44:47 UTC 2025


On Wed, 17 Sep 2025 20:11:39 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Renaming it to `self_suspend()` is also a good choice IMHO. :)
>
> The 'self_suspend' is the first attempt, but I agree with @pchilano that it is better to have something similar to
> 'set_suspended' since the method is doing the same. It not fully suspend but only set status. 
> The another possible name that might be:
> 'set_suspended_current_thread'
> to make clear that it is for "self suspension" purpose only.
> while the 'with_id' part is clear from the parameters.

Given the asymmetry (we don't need a resume path that works with id) I think what you have will do. I just suggest some altered comments below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27317#discussion_r2356729138


More information about the serviceability-dev mailing list