RFR: 8367725: Incorrect reading of oop in SuspendResumeManager::suspend while thread is blocked [v10]

[David Holmes]

On Wed, 17 Sep 2025 21:23:42 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The
>> `SuspendResumeManager::suspend(bool register_vthread_SR)`
>> has an issue while suspend current virtual thread. The suspend tries to access vthread oop field to read vthread id after thread is blocked. 
>> 
>> Seems, that this case is not used by our debugger and was not covered by tests. I found it using jtreg test thread virtual factory plugin. I updated existing test to reproduce this problem. The easiest way is to suspend current virtual thread using plain SuspendThread. 
>> 
>> The fix added some "asymmetry"  in suspend/resume mechanism which is required because self-suspend doesn't have resume counterpart.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   renamed method

src/hotspot/share/runtime/suspendResumeManager.cpp line 88:

> 86:   if (register_vthread_SR) {
> 87:     assert(_target->is_vthread_mounted(), "sanity check");
> 88:     assert(_target == JavaThread::current(), "should be current thread");

So this assert should be outside the INCLUDE_JVMTI section - right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27317#discussion_r2357499917