RFR: 8361955: [GCC static analyzer] libjdwp/threadControl.c threadControl_setPendingInterrupt error: dereference of NULL 'node'

[David Holmes]

On Thu, 18 Sep 2025 22:26:26 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Fix gcc static analyzer warning. It was introduced by [JDK-8324868](https://bugs.openjdk.org/browse/JDK-8324868) early last year. For the most part the fix is to revert the relevant [JDK-8324868](https://bugs.openjdk.org/browse/JDK-8324868) changes, except for leaving in the replacement of calling findThread() with instead calling findRunningThread().
> 
> Ran all svc tier2 and tier5 tests.

It fixes the warning but surely impossible to be calling this function in such circumstances?

Static analyzers often lack context that would tell them something can't be null. Normally, in main hotspot code, asserts seem to do the job of telling the analyzer this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/27378#pullrequestreview-3242922515