RFR: 8365191: Cleanup after removing LockingMode related code [v2]

Fredrik Bredberg fbredberg at openjdk.org
Wed Sep 24 12:01:46 UTC 2025


On Wed, 24 Sep 2025 11:13:42 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 171:
>> 
>>> 169:   nonstatic_field(Array<Klass*>,               _data[0],                               Klass*)                                       \
>>> 170:                                                                                                                                      \
>>> 171:   volatile_nonstatic_field(BasicLock,          _monitor,                               ObjectMonitor*)                               \
>> 
>> I don't see any references to this in the JVMCI code either.  I assume the compiler/jvmci tests all passed with this change without any change to jvmci code.  Maybe @mur47x111  can confirm.
>
> Correct, I dont think JVMCI tests will be affected. We only use this field (offset) in the actual monitorenter implementation to write ObjectMonitor cache.
> edit: Sorry I missed the `delete it from vmStructs` context. We need this line for our fast locking implementation

Removed line 171 from `vmStructs_jvmci.cpp`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27448#discussion_r2375544175


More information about the serviceability-dev mailing list